[No QA] Replace contributorValidationGate with isAuthorizedContributor action by roryabraham · Pull Request #91485 · Expensify/App

roryabraham · 2026-05-23T00:41:10Z

Explanation of Change

Background

contributorValidationGate.yml had four callers:

Workflow	Purpose
claude-review.yml	Gates Claude auto-review on pull_request_target
validateContributorPR.yml	Closes/locks PRs from unauthorized contributors
authorChecklist.yml	Skips the checklist job for unauthorized authors
cla.yml	Skips the CLA signing job for unauthorized authors

What this PR changes

Replaces the contributorValidationGate reusable workflow (which unnecessarily spins up a new runner per caller) with a TypeScript isAuthorizedContributor GitHub action built via ncc.
Authorization now includes membership in the Expensify contributor-plus org team (via OS_BOTIFY_TOKEN), in addition to existing association, linked-issue assignee, and linked-PR reviewer checks. This is safe for all current use-cases but worht noting - Contributor+ will be able to open pull requests and have them auto-reviewed by Claude.

Fixed Issues

side-quest for #90214

Tests

Automated tests only.

Offline tests

N/A – GitHub Actions only.

QA Steps

N/A – GitHub Actions only.

PR Author Checklist

Screenshots/Videos

N/A

Centralize gate logic and Contributor+ team membership ahead of linked issue/PR checks. Co-authored-by: Cursor <cursoragent@cursor.com>

Bundle contributor authorization into a node24 action with ncc and rebuild actions that embed CONST after adding contributor-plus team slug. Co-authored-by: Cursor <cursoragent@cursor.com>

…or action Colocate authorization checks in caller workflows and authorize Contributor+ team members. Co-authored-by: Cursor <cursoragent@cursor.com>

Local actions require the repository on the runner per App workflow guidelines. Co-authored-by: Cursor <cursoragent@cursor.com>

Match @octokit/request-error RequestErrorOptions shape for typecheck. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove ContributorAuthorization lib; export helpers from the action entry for unit tests. Drop CONTRIBUTOR_PLUS_TEAM_SLUG from CONST. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Dedupe link parsing and error logging; add isMatchingLogin helper. Co-authored-by: Cursor <cursoragent@cursor.com>

PR template issue links are visible and placeholders in comments do not match issue IDs. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove loginsMatch and isMatchingLogin helpers. Co-authored-by: Cursor <cursoragent@cursor.com>

Being the author or reviewer of some unrelated PR is not a meaningful authorization signal; contributors with merged PRs already have CONTRIBUTOR association which is checked first. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot · 2026-05-23T02:00:23Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0b1831a2b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-23T02:04:00Z

+    const prBody = pr.body ?? '';
+    const isAuthorized = await isAuthorizedViaLinkedIssues(prBody, prAuthor);


Restore linked-PR authorization checks for contributors

This change regresses the contributor gate by removing the linked-PR authorization path: isAuthorizedContributor() now only evaluates isAuthorizedViaLinkedIssues(...) after loading the PR body, so external authors who are valid via a linked PR (author/reviewer/requested reviewer) are incorrectly treated as unauthorized. That breaks the prior behavior used by validateContributorPR.yml/claude-review.yml and can cause legitimate contributor PRs to be auto-closed or skipped from downstream workflows.

Useful? React with 👍 / 👎.

I intentionally removed this. Here's a snippet from my conversation with Claude:

Rory: What does this function imply? That a contributor can open a pull request because they have another one open? Do we need that for something, or could we just remove it entirely?
...
Claude: The logic implies three separate authorization paths via linked PRs:

You authored the linked PR (you've already contributed work)

You reviewed the linked PR (you've already done review work)

You were requested to review the linked PR (an internal team member nominated you)

The third case (#3 — requested reviewer) is the most defensible: it's essentially "an Expensify employee explicitly invited this person to be involved." But cases #1 and #2 are weak — having authored or reviewed some other PR doesn't really mean you're authorized to open this one.

More importantly, if someone had a PR merged (case #1), they'd already have the CONTRIBUTOR association, which is checked first and would short-circuit before ever reaching this function. So the "you authored a linked PR" path only fires for unmerged PRs — which is even less meaningful as an authorization signal.

The linked issues check is the principled one: being assigned to an issue means someone explicitly tasked you with the work. The linked PR check has no equivalent clear intent.

My recommendation: Remove isAuthorizedViaLinkedPullRequests entirely. The only case worth preserving might be "requested reviewer," but that's a very unusual path and I'd want to know if it was ever actually used before keeping the complexity. Want me to delete the function and update the tests?

…ontributor Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # .github/workflows/authorChecklist.yml # .github/workflows/claude-review.yml

mountiny · 2026-05-25T10:57:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Copilot

Pull request overview

This PR replaces the reusable contributorValidationGate workflow with a bundled TypeScript GitHub Action (isAuthorizedContributor) to centralize and reuse external-contributor authorization checks without spinning up a separate runner per caller.

Changes:

Added a new Node 24 JavaScript action (isAuthorizedContributor) that determines whether a PR author is authorized (association, Contributor+ team membership, linked issue assignee).
Updated gating workflows (claude-review, authorChecklist, cla, validateContributorPR) to checkout first and then call the local action directly.
Removed the contributorValidationGate.yml reusable workflow and wired the new action into the action build script and unit tests.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`tests/unit/isAuthorizedContributorTest.ts`	Adds unit coverage for the new authorization logic.
`.github/actions/javascript/isAuthorizedContributor/action.yml`	Defines the new Node 24 GitHub Action interface (inputs/outputs).
`.github/actions/javascript/isAuthorizedContributor/isAuthorizedContributor.ts`	Implements authorization logic (association, Contributor+, linked issues) and sets action output.
`.github/actions/javascript/isAuthorizedContributor/index.js`	Bundled ncc output used by the action runner.
`.github/scripts/buildActions.sh`	Includes the new action entrypoint in the build list.
`.github/workflows/validateContributorPR.yml`	Switches from reusable workflow to local action and gates close/lock behavior on the action output.
`.github/workflows/contributorValidationGate.yml`	Removes the no-longer-needed reusable gate workflow.
`.github/workflows/claude-review.yml`	Inlines authorization gating via the local action and centralizes “authorized” branching.
`.github/workflows/cla.yml`	Replaces reusable gate workflow usage with the local action and exposes `IS_AUTHORIZED` as a job output.
`.github/workflows/authorChecklist.yml`	Runs the local gate action and only executes the checklist step when authorized.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,25 @@
+name: 'Is Authorized Contributor'
+description: 'Checks whether a PR author is authorized to contribute (org member, Contributor+, or linked issue/PR)'


codecov · 2026-05-26T00:02:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 261 files with indirect coverage changes

roryabraham · 2026-05-26T00:09:08Z

@mountiny updated and ready for another review

mountiny

Thank you!

OSBotify · 2026-05-26T17:56:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-26T20:38:39Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.3.83-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-27T17:28:16Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

roryabraham and others added 4 commits May 22, 2026 17:24

Add ContributorAuthorization lib for external contributor checks

0fc82f5

Centralize gate logic and Contributor+ team membership ahead of linked issue/PR checks. Co-authored-by: Cursor <cursoragent@cursor.com>

Add isAuthorizedContributor GitHub action

fb3d1f0

Bundle contributor authorization into a node24 action with ncc and rebuild actions that embed CONST after adding contributor-plus team slug. Co-authored-by: Cursor <cursoragent@cursor.com>

Replace contributorValidationGate workflow with isAuthorizedContribut…

c15d2aa

…or action Colocate authorization checks in caller workflows and authorize Contributor+ team members. Co-authored-by: Cursor <cursoragent@cursor.com>

Checkout before isAuthorizedContributor in gated workflows

dc66011

Local actions require the repository on the runner per App workflow guidelines. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot Bot assigned roryabraham May 23, 2026

roryabraham and others added 2 commits May 22, 2026 17:51

Rebuild gh actions

0dea1f0

Fix RequestError mock options in ContributorAuthorizationTest

e5fc210

Match @octokit/request-error RequestErrorOptions shape for typecheck. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham mentioned this pull request May 23, 2026

Migrate standard codex installation to a GitHub Action #90214

Open

roryabraham and others added 8 commits May 22, 2026 17:59

Colocate contributor auth logic in isAuthorizedContributor action

782349d

Remove ContributorAuthorization lib; export helpers from the action entry for unit tests. Drop CONTRIBUTOR_PLUS_TEAM_SLUG from CONST. Co-authored-by: Cursor <cursoragent@cursor.com>

Rename ContributorAuthorizationTest to isAuthorizedContributorTest

9fe8787

Co-authored-by: Cursor <cursoragent@cursor.com>

Simplify isAuthorizedContributor without behavior change

a4b4250

Dedupe link parsing and error logging; add isMatchingLogin helper. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove stripHtmlComments from isAuthorizedContributor

4422a7c

PR template issue links are visible and placeholders in comments do not match issue IDs. Co-authored-by: Cursor <cursoragent@cursor.com>

Inline login matching in isAuthorizedContributor

6173256

Remove loginsMatch and isMatchingLogin helpers. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove isAuthorizedViaLinkedPullRequests

cb51268

Being the author or reviewer of some unrelated PR is not a meaningful authorization signal; contributors with merged PRs already have CONTRIBUTOR association which is checked first. Co-authored-by: Cursor <cursoragent@cursor.com>

Simplify core.setOutput call, boolean is coerced to string automatically

256f73a

Co-authored-by: Cursor <cursoragent@cursor.com>

Remove extraneous change

dbbacf6

roryabraham force-pushed the chore/is-authorized-contributor branch from 864e3a2 to dbbacf6 Compare May 23, 2026 01:35

roryabraham and others added 3 commits May 22, 2026 18:53

DRY up claude-review.yml with a set-authorized step

e2a19cf

Co-authored-by: Cursor <cursoragent@cursor.com>

Use useblacksmith/checkout in place of actions/checkout

76b12fa

Co-authored-by: Cursor <cursoragent@cursor.com>

Remove outdaterd hash

c0b1831

roryabraham requested a review from mountiny May 23, 2026 01:59

roryabraham marked this pull request as ready for review May 23, 2026 01:59

roryabraham requested a review from a team as a code owner May 23, 2026 01:59

melvin-bot Bot requested a review from stitesExpensify May 23, 2026 02:00

melvin-bot Bot removed the request for review from a team May 23, 2026 02:00

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into chore/is-authorized-c…

ff048e8

…ontributor Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # .github/workflows/authorChecklist.yml # .github/workflows/claude-review.yml

mountiny requested a review from Copilot May 25, 2026 10:57

Copilot started reviewing on behalf of mountiny May 25, 2026 10:58 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

mountiny reviewed May 25, 2026

View reviewed changes

Comment thread .github/workflows/validateContributorPR.yml Outdated

Comment thread .github/actions/javascript/isAuthorizedContributor/action.yml Outdated

roryabraham added 3 commits May 25, 2026 16:47

Remove comment references to an open PR as an authorizing factor

389dd8f

Make GITHUB_TOKEN and OS_BOTIFY_TOKEN required params for the action

5215bb1

Don't hard-fail on unknown errors for the Contributor+ check

3b69723

roryabraham requested a review from mountiny May 26, 2026 00:08

mountiny approved these changes May 26, 2026

View reviewed changes

stitesExpensify approved these changes May 26, 2026

View reviewed changes

stitesExpensify merged commit c996790 into main May 26, 2026
36 checks passed

stitesExpensify deleted the chore/is-authorized-contributor branch May 26, 2026 17:45

OSBotify mentioned this pull request May 26, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

		const prBody = pr.body ?? '';
		const isAuthorized = await isAuthorizedViaLinkedIssues(prBody, prAuthor);

		@@ -0,0 +1,25 @@
		name: 'Is Authorized Contributor'
		description: 'Checks whether a PR author is authorized to contribute (org member, Contributor+, or linked issue/PR)'

Conversation

roryabraham commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Background

What this PR changes

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham May 23, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny commented May 25, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roryabraham commented May 26, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented May 23, 2026 •

edited

Loading

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading